Fix MariaDB test container failing to start #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the recently failing GitHub Actions test workflows, in which the MariaDB Docker container failed to start. The issue seems to have been using the `mysqladmin` command for health checking in `test.yml`, probably due to the following change in MariaDB v11.0.1: (Copied from https://mariadb.com/kb/en/mariadb-11-0-1-release-notes/) """ ## Docker Official Images * 11.0, unlike previous version, no longer includes mysql named compatible executable symlinks inside the container. """ https://mariadb.com/kb/en/mysqladmin/ mentions that `mariadb-admin` is now the new name of the script (previously `mysqladmin`). Also replaced the `MYSQL_DATABASE` and `MYSQL_ROOT_PASSWORD` environment variables with their new names (based on the docs: https://mariadb.com/kb/en/mariadb-server-docker-official-image-environment-variables/).
Codecov Report
@@ Coverage Diff @@
## master #1200 +/- ##
=======================================
Coverage 97.30% 97.30%
=======================================
Files 23 23
Lines 1262 1262
Branches 204 204
=======================================
Hits 1228 1228
Misses 16 16
Partials 18 18 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue seems to have been using the
mysqladmincommand for health checking intest.yml, probably due to the following change in MariaDB v11.0.1:The docs on
mysqladminmention thatmariadb-adminis now the new name of the script.Also replaced the
MYSQL_DATABASEandMYSQL_ROOT_PASSWORDenvironment variables with their new names (based on the docs on the Docker image's env vars).Related Issue
Motivation and Context
How Has This Been Tested?
Through GitHub Actions.
Screenshots (if appropriate):
Types of changes
Checklist:
pre-commit runcommand to format and lint.AUTHORS.rstCHANGES.rst